Skip to content
IonWarpTry for free
Code review terms

PTAL, nit, SGTM: code review terms and what they mean

PTAL means "please take a look": on GitHub, a request to review a pull request, or to check it again after fixes. A nit, short for nitpick, is a small code review comment the author may skip.[1] SGTM agrees with a plan, not with the code. Few code review terms can hold a merge on GitHub, and the table below lists them. IonWarp, an AI reviewer for GitHub pull requests, says which of its own comments block a merge.

sentry#93824
Span Buffer Multiprocess Enhancement with Health Monitoring
Span Buffer Multiprocess Enhancement with Health Monitoringsentry #93824
IonWarp caught it Qodo, Greptile, Cursor Bugbot and CodeRabbit missed it
IonWarpbotcommented

isinstance check at line 254 tests against multiprocessing.Process which is the default context's ForkProcess class, not the SpawnProcess class created by multiprocessing.get_context('spawn'), causing the check to always be False on Linux and preventing process.kill() from being called on unhealthy workers · Code Review

HighKnown issue in the Code Review benchmark · caught by DeepSeek V4.1 FlashSee the graded case

LGTM means "looks good to me": a reviewer writes it to approve a pull request.[2] LGTM meaning covers what it does on GitHub, Gerrit and Kubernetes. We counted these words on 1,129 merged pull requests from 12 open-source projects: LGTM turned up on 265 of them, a nit on 80, PTAL on 9 and SGTM on 2. This page is for anyone decoding a review comment; it is not a guide to running a review.

Code review terms and acronyms

  • LGTM

    Looks good to me: the reviewer approves the change.[2] "LGTM with comments" approves it while leaving small points the author fixes before merging.[3] More in LGTM meaning.

  • PTAL

    Short for "please take a look", in code review, chat or work email. An author sends it to ask for a review, and again after pushing fixes, when it means "please take another look". On GitHub the same request is a button: the Re-request review icon next to a reviewer's name asks them to review the pull request again.[4] More in PTAL meaning.

  • SGTM

    Sounds good to me. Agreement with a plan or an answer in the thread, not an approval of the code.

  • Nit

    Short for nitpick: a minor point, such as "nit: rename cnt to retryCount". Google's review guide labels such comments "Nit:", something worth doing that will not hugely matter, so the author knows it is optional.[1] Conventional Comments labels it "nitpick:", a trivial, preference-based request that should not block.[5] A formatting nit is one a linter can make instead. More in nit meaning in code review.

  • WIP and RFC

    Work in progress: not ready for review yet. Request for comments: the author wants feedback on the approach before polishing the code.

  • ACK and NACK

    Acknowledged and not acknowledged: agreement with a change, or an objection to it, as written on mailing-list projects.

  • Approve, Request changes, Comment

    GitHub's three review decisions. Approve says the change is ready to merge, Request changes flags feedback to address before merging, and Comment leaves feedback without either. Administrators make approvals required with GitHub branch protection rules.[6]

  • Merge request vs pull request

    The same thing under two names: a pull request on GitHub, a merge request on GitLab.[7][8] GitHub's head and base branch are GitLab's source and target branch. The names come from the two ends of one step: git request-pull asks a maintainer to pull your branch,[9] and GitLab names the merge. IonWarp reviews GitHub pull requests, not GitLab merge requests.

  • Blocking and non-blocking

    Whether a comment must be resolved before the change is accepted. Conventional Comments adds a (blocking) or (non-blocking) tag to the comment.[5] The code review checklist says what to look for.

  • Stacked pull request

    One of a chain of small pull requests, each based on the branch of the one below, so each can be reviewed and merged on its own. GitHub supports them in public preview.[10]

  • Rubber stamp

    An approval given without really reading the change. A one-minute LGTM on a 2,000-line diff is usually one.

  • P0, P1, P2

    IonWarp labels each finding P0, P1 or P2. By default a P0 sets the GitHub check to Action required. A P2 is real but can wait; the review comment lists it as a nitpick.

    Code ReviewOn Starter, Pro and Max

How often do these terms appear on real pull requests?

  1. LGTM usually comes with a click

    Of the 265 pull requests with an LGTM, 96 were in Kubernetes. Elsewhere, a reviewer who wrote it also clicked Approve 182 times out of 190.

  2. Nits rarely demand changes

    Of 160 nits left inside a review, 126 sat in a Comment review, 25 in an Approve, 7 in reviews since dismissed and 2 in Request changes.

  3. Where these numbers come from

    On November 10, 2026 we took up to 100 recently updated pull requests by human authors, merged since May 10, from each of Kubernetes, Rust, Node.js, React, VS Code, Django, Rails, PyTorch, Grafana, Terraform, Kafka and Elasticsearch. Bots, quotes and code are left out. These projects are our choice, and GitHub as a whole may look different.

Which code review terms block a merge on GitHub?

Typed words hold nothing on their own. Of these terms, only a draft, a required review, a required check or, on a branch that asks for it, an open thread can hold a merge.

CriterionIonWarpOn GitHub
LGTM, SGTM or PTAL in a commentNever approves; needs no PTALHolds nothing; only an Approve review counts toward required reviews[11]
NitA P2 finding, listed as a nitpickHolds nothing unless the branch requires conversation resolution[12]
Request changes reviewNever submits one; a P0 sets the check insteadInformational unless a rule requires a pull request; then that reviewer must approve, or the review be dismissed[11][12]
Draft pull requestSkipped by defaultCannot be merged[7]
Required status checkBy default a P0 is Action required, a P1 Neutral and a P2 SuccessMust be successful, skipped or neutral to merge[12]
Pricing

Simple pricing for your whole team.

One workspace price with seats included. Credits pool across your team. Unlimited repos on every plan.

Starter

$0 /mo

Try AI PR review.

  • 2 reviewers
    • Code Review
    • Security Review
  • 3 seats included
  • 15,000 credits to start, then 5,000/mo
  • About 70 reviews to start, then about 25 a month
  • Unlimited repos
Get Started

Max

$149 /mo

Scale AI PR review.

  • +9 reviewers
    • UX Review
    • API Performance
    • Analytics Review
    • SEO Review
    • Changelog
    • CI/CD Performance
    • Plan Review
    • Repeat-Failure Learnings
    • SOC 2 Review
  • 10 seats included
  • +75,000 credits/mo
  • About 360 reviews a month
  • +$29/mo per added seat
  • Unlimited repos
  • Priority support
Choose Max
Enterprise

Custom reviewers + credits · GitHub Enterprise · SSO/SAML + audit logs · Custom security review + SLA

Contact us
FAQ

Frequently asked questions

What does PTAL mean?

Please take a look. Authors use it to ask for a first review, and again after pushing fixes, when it reads as "please take another look". On a GitHub pull request, the Re-request review icon next to the reviewer's name asks the same thing.

What does SGTM mean?

Sounds good to me. It agrees with a plan or an answer in a thread; unlike LGTM, it does not approve the code.

What does nit mean in code review?

A nit, short for nitpick, is a small, optional suggestion: a name, a comment, a formatting choice. Starting the comment with "nit:" tells the author it will not block the merge.

What is the difference between Approve and Request changes?

Approve says the change is ready to merge. Request changes asks the author to address the feedback before merging. A Comment review does neither.

How does IonWarp mark blocking findings?

Every finding is P0, P1 or P2. P0 and P1 should be fixed before merging; a P2 is real but can wait, and the review comment lists it as a nitpick. By default a P0 sets IonWarp's GitHub check to Action required.

Sources

  1. How to write code review commentsGoogle · read
  2. Google Engineering Practices: TerminologyGoogle · read
  3. Speed of Code ReviewsGoogle · read
  4. Requesting a pull request reviewGitHub Docs · read
  5. Conventional CommentsConventional Comments · read
  6. Pull request reviewsGitHub Docs · read
  7. About pull requestsGitHub Docs · read
  8. Merge requestsGitLab Docs · read
  9. git-request-pull documentationGit · read
  10. About stacked pull requestsGitHub Docs · read
  11. Approving a pull request with required reviewsGitHub Docs · read
  12. About protected branchesGitHub Docs · read