Skip to content
IonWarpTry for free
What is a pull request

What is a pull request? How a GitHub pull request works

“Pull requests are proposals to merge code changes into a project.”[1] You push your commits to a branch, open a pull request against the branch you want them in, and the team reviews the diff before it merges.

sentry#93824
Span Buffer Multiprocess Enhancement with Health Monitoring
Span Buffer Multiprocess Enhancement with Health Monitoringsentry #93824
IonWarp caught it Qodo, Greptile, Cursor Bugbot and CodeRabbit missed it
IonWarpbotcommented

isinstance check at line 254 tests against multiprocessing.Process which is the default context's ForkProcess class, not the SpawnProcess class created by multiprocessing.get_context('spawn'), causing the check to always be False on Linux and preventing process.kill() from being called on unhealthy workers · Code Review

HighKnown issue in the Code Review benchmark · caught by DeepSeek V4.1 FlashSee the graded case

GitLab calls the same thing a merge request.[2] PR is short for pull request, and the name comes from git itself: git request-pull asks a maintainer to pull your branch.[3]

What a pull request holds

  • Conversation

    The description, the timeline, the comments and the reviews.[1]

  • Commits

    How the pull request's branch changed over time.[1]

  • Checks

    The automated tests, builds and other validations that run on it.[1]

  • Files changed

    The diff the reviewers read.[1]

  • Draft

    A draft pull request cannot be merged, and code owners are not asked to review it: a way to share work in progress before asking for review.[1] The pull request checklist is for when it is ready.

How a pull request moves from open to merged

git switch -c fix-login-redirect
git commit -am "Fix the login redirect"
git push -u origin fix-login-redirect
gh pr create --base main --title "Fix the login redirect" --body "Returns users to the page they came from."
  1. When to open a pull request

    Open one when someone else should read a change before it reaches a shared branch, or when you can't push to the repository. On a solo repository with no required reviews or checks, skip it and push to the branch directly.

  2. A branch or a fork

    On a team, collaborators push topic branches to one shared repository. On open source, anyone who can read a repository can fork it and open a pull request from the fork.[1]

  3. How to open a pull request

    Push your branch, then click Compare & pull request in the banner on GitHub, or run gh pr create in a terminal. The base branch is where you want the changes and the compare branch holds them. A title and a description tell reviewers what they are reading.[4]

  4. Review

    Reviewers comment, approve or request changes.[5] Request changes does not block the merge unless a ruleset or branch protection rule requires reviews.[6] How to review a pull request walks through it, and the code review checklist says what to look for.

  5. What it means to approve a pull request

    Approving signals that the changes are ready to merge.[5] An author cannot approve their own pull request. With required reviews and stale review dismissal on, a new commit that changes code dismisses an approval.[6] An approval is often written LGTM.

  6. Merge

    A merge commit keeps every commit and adds one that joins the branch. Squash and merge combines the commits into one. Rebase and merge adds each commit onto the base branch without a merge commit.[7]

  7. What closing a pull request means

    Closing ends a pull request without merging it. GitHub says it fits a change that is no longer needed or that other work has replaced, and that the discussion and history stay for reference.[8]

What is a good pull request size?

A good pull request is small enough to serve one purpose. GitHub's docs say small, focused pull requests are easier to review and safer to merge, and they set no line limit.[9] We split the 50 open-source PRs in Martian's code review benchmark by changed lines; the median is 280 changed lines and 8 files. On average, nine AI reviewers found about half the known issues at every size up to 1,000 lines, while findings that matched no known issue rose from 1.0 per reviewer per PR at up to 300 lines to 1.8 above that.[10] IonWarp's column is Code Review, which is about average on what it finds and noisier than average past 300 lines. These PRs were picked because they hold known bugs, a finding that matched none is not always wrong, and only 3 are over 1,000 lines.

CriterionIonWarpAll 9 reviewers, known issues foundAll 9 reviewers, findings that matched none
Up to 100 changed lines (11 PRs)12 of 23 known issues, 1.0 matched none per PR47%[10]1.0 per PR[10]
101 to 300 changed lines (16 PRs)26 of 45 known issues, 1.0 matched none per PR52%[10]1.1 per PR[10]
301 to 1,000 changed lines (20 PRs)35 of 79 known issues, 2.1 matched none per PR47%[10]1.8 per PR[10]
Over 1,000 changed lines (3 PRs)4 of 11 known issues, 3.0 matched none per PR30%[10]2.0 per PR[10]
Pricing

Simple pricing for your whole team.

One workspace price with seats included. Credits pool across your team. Unlimited repos on every plan.

Starter

$0 /mo

Try AI PR review.

  • 2 reviewers
    • Code Review
    • Security Review
  • 3 seats included
  • 15,000 credits to start, then 5,000/mo
  • About 70 reviews to start, then about 25 a month
  • Unlimited repos
Get Started

Max

$149 /mo

Scale AI PR review.

  • +9 reviewers
    • UX Review
    • API Performance
    • Analytics Review
    • SEO Review
    • Changelog
    • CI/CD Performance
    • Plan Review
    • Repeat-Failure Learnings
    • SOC 2 Review
  • 10 seats included
  • +75,000 credits/mo
  • About 360 reviews a month
  • +$29/mo per added seat
  • Unlimited repos
  • Priority support
Choose Max
Enterprise

Custom reviewers + credits · GitHub Enterprise · SSO/SAML + audit logs · Custom security review + SLA

Contact us
FAQ

Frequently asked questions

What is a pull request on GitHub?

A proposal to merge code changes into a project. It shows the diff, runs the checks and collects the reviews, and a maintainer merges it when it is ready.

Is a pull request the same as git pull?

No. Git's documentation describes git pull as a command that fetches from a remote and integrates the result into your current branch. A pull request is a feature of GitHub and similar hosts that proposes merging one branch into another and collects the review. The closest thing in Git itself is git request-pull, which only prints a request as text.

What is the difference between a pull request and a merge request?

None: GitHub says pull request, GitLab says merge request. GitHub's head and base branch are GitLab's source and target branch.

What is a draft pull request?

A pull request marked as work in progress. It cannot be merged, and code owners are not asked to review it until it is marked ready, with the Ready for review button in the merge box.

Can you approve your own pull request?

No. GitHub does not let a pull request's author approve it; another person with access must.

What does squash and merge do?

It combines the pull request's commits into one commit on the base branch, so the history shows one commit per pull request.

Sources

  1. About pull requestsGitHub Docs · read
  2. Merge requestsGitLab Docs · read
  3. git-request-pull documentationGit · read
  4. Creating a pull requestGitHub Docs · read
  5. Pull request reviewsGitHub Docs · read
  6. Approving a pull request with required reviewsGitHub Docs · read
  7. About merge methods on GitHubGitHub Docs · read
  8. Deploying codeGitHub Docs · read
  9. Helping others review your changesGitHub Docs · read
  10. The code review benchmark: 50 pull requests, 158 known issues (release of 2026-10-06)IonWarp benchmark · read